Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "No data available" display when list is empty #33517

Merged
merged 7 commits into from
Feb 8, 2025
Merged

Add "No data available" display when list is empty #33517

merged 7 commits into from
Feb 8, 2025

Conversation

kerwin612
Copy link
Member

Add a "No data available" message to be displayed when the list has no data. This improves the user experience by providing clear feedback in an empty state.

before:
7f7397edc5345a831b7aea837b456e7

after:
image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 6, 2025
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2025
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Feb 6, 2025
@wxiaoguang

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Feb 7, 2025
@kerwin612 kerwin612 requested a review from wxiaoguang February 8, 2025 00:47
@lunny lunny added this to the 1.24.0 milestone Feb 8, 2025
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Feb 8, 2025
wxiaoguang
wxiaoguang reviewed Feb 8, 2025
View reviewed changes
templates/admin/auth/list.tmpl Outdated Show resolved Hide resolved
templates/admin/emails/list.tmpl Outdated Show resolved Hide resolved
templates/admin/notice.tmpl Outdated Show resolved Hide resolved
templates/admin/org/list.tmpl Outdated Show resolved Hide resolved
templates/admin/packages/list.tmpl Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Feb 8, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Feb 8, 2025
@wxiaoguang wxiaoguang merged commit a52720b into go-gitea:main Feb 8, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the feat/add-no-data-display-when-list-empty branch February 8, 2025 16:13
zjjhot added a commit to zjjhot/gitea that referenced this pull request Feb 10, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
a32db18 
* giteaofficial/main:
  Feature: Support workflow event dispatch via API (go-gitea#32059)
  Remove "class-name" from svg icon (go-gitea#33540)
  Add "No data available" display when list is empty (go-gitea#33517)
  Add a option "--user-type bot" to admin user create, improve role display (go-gitea#27885)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files size/S Denotes a PR that changes 10-29 lines, ignoring generated files. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
5 participants
@kerwin612 @wxiaoguang @hiifong @lunny @GiteaBot