Move organization's visibility change to danger zone. #34814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
added
the
type/refactoring
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
wxiaoguang
reviewed
Jun 22, 2025
wxiaoguang
reviewed
Jun 22, 2025
hiifong
approved these changes
Jul 3, 2025
GiteaBot
added
lgtm/need 1
wxiaoguang
reviewed
Jul 5, 2025
wxiaoguang
reviewed
Jul 5, 2025
wxiaoguang
reviewed
Jul 6, 2025
wxiaoguang
reviewed
Jul 6, 2025
wxiaoguang
reviewed
Jul 6, 2025
wxiaoguang
reviewed
Jul 6, 2025
…nto lunny/refactor_org_setting
wxiaoguang
reviewed
Jul 7, 2025
wxiaoguang
reviewed
Jul 7, 2025
wxiaoguang
reviewed
Jul 7, 2025
wxiaoguang
reviewed
Jul 8, 2025
wxiaoguang
reviewed
Jul 8, 2025
lafriks
reviewed
Jul 8, 2025
wxiaoguang
reviewed
Jul 9, 2025
wxiaoguang
reviewed
Jul 9, 2025
| func SettingsChangeVisibilityPost(ctx *context.Context) { | ||
| visibility := structs.VisibilityModes[ctx.FormString("visibility")] | ||
| if !visibility.IsValid() { | ||
| ctx.JSONError(ctx.Tr("org.settings.invalid_visibility")) |
There was a problem hiding this comment.
End users would never see such error message, so please re-use the existing invalid_data tranlsation
wxiaoguang
reviewed
Jul 9, 2025
| } | ||
|
|
||
| if ctx.Org.Organization.Visibility == visibility { | ||
| ctx.JSONError(ctx.Tr("org.settings.change_visibility_no_change")) |
There was a problem hiding this comment.
It shouldn't be an "error". It can just flash a info or success message.
And there can be a general message that "You did not make any changes"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.