Skip to content

Display badge on blocked & blocking issues #35004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Naxdy
Copy link
Contributor

@Naxdy Naxdy commented Jul 8, 2025

This PR supersedes #29117 by offering a more simplistic approach to the problem. Any issue / PR that is blocked by another issue / PR, or is blocking one or more issues / PRs now has a badge displayed next to it indicating as such, right before the labels.

Both cases are represented by different icons, so it is easy to see at a glance which issues / PRs require attention more urgently than others (look for the ones that are blocking the most).

Only open issues / PRs are considered for determining blocking items, and closed issues / PRs cannot "block" anything anymore, but can still be "blocked by" something, in case an issue was closed due to being cancelled as opposed to implemented.

In the future, we might even think about adding a tooltip that lists the individual issues that are blocking / blocked.


Closes #29018

Screenshots

Issue List (Repo)

image

PR List (Repo)

image

Issue List (Global)

image

Unresolved questions

  • Is style="background: none;" fine? It feels hacky, and like there should be a better way without adding a whole new class 🤔

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 8, 2025
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 8, 2025
@Naxdy Naxdy force-pushed the work/mark-blocked-issues branch 2 times, most recently from 5c109c0 to dbaba71 Compare July 9, 2025 06:21
@anbraten
Copy link
Contributor

anbraten commented Jul 9, 2025

You could use tw-hidden from tailwind instead of style="background: none;"

@Naxdy
Copy link
Contributor Author

Naxdy commented Jul 9, 2025

Unfortunately tw-hidden makes the entire element disappear. The background: none is only to clear the background color, as otherwise the badge appears like this, which imo kinda clashes with the red color:

image

@Naxdy Naxdy force-pushed the work/mark-blocked-issues branch from dbaba71 to 84b5ab0 Compare July 9, 2025 06:46
@Naxdy Naxdy force-pushed the work/mark-blocked-issues branch from 84b5ab0 to e6da758 Compare July 9, 2025 06:58
@anbraten
Copy link
Contributor

anbraten commented Jul 9, 2025

Ahh sorry, bg-transparent might be it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/frontend modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the PR list page show if a PR is blocked by another issue/PR.
3 participants