Skip to content

Improve submodule relative path handling #35056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Improve submodule relative path handling #35056

wants to merge 4 commits into from
+98 −102

Conversation

wxiaoguang
Copy link
Contributor

Fix #35054

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 12, 2025
@github-actions github-actions bot added modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files labels Jul 12, 2025
This was referenced Jul 12, 2025
Open
Merged
@wxiaoguang wxiaoguang added this to the 1.25.0 milestone Jul 12, 2025
@wxiaoguang wxiaoguang added the type/enhancement An improvement of existing functionality label Jul 12, 2025
@wxiaoguang wxiaoguang changed the title Fix submodule relative path handling Improve submodule relative path handling Jul 12, 2025
@wxiaoguang wxiaoguang force-pushed the fix-submodule-relpath branch 2 times, most recently from 0219371 to 88b857c Compare July 12, 2025 02:52
@wxiaoguang wxiaoguang force-pushed the fix-submodule-relpath branch from 88b857c to 7e4db07 Compare July 12, 2025 07:10
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 12, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lunny lunny lunny approved these changes

@hiifong hiifong hiifong approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

relative submodule PR diff links not working
4 participants
@wxiaoguang @lunny @hiifong @GiteaBot