Skip to content

Upgrade to go 1.25.3 #35656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 15, 2025
Merged

Upgrade to go 1.25.3 #35656

merged 4 commits into from
Oct 15, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 14, 2025

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 14, 2025
@silverwind
Copy link
Member

Test failure may be related:

--- FAIL: TestParseGitURLs (0.00s)
    --- FAIL: TestParseGitURLs/https://[fe80:14fc:cec5:c174:d88%2510]:20/go-gitea/gitea.git (0.00s)
        url_test.go:167: 
            	Error Trace:	/home/runner/work/gitea/gitea/modules/git/url/url_test.go:167
            	Error:      	Received unexpected error:
            	            	parse "https://[fe80:14fc:cec5:c174:d88%2510]:20/go-gitea/gitea.git": invalid host: ParseAddr("fe80:14fc:cec5:c174:d88%10"): address string too short
            	Test:       	TestParseGitURLs/https://[fe80:14fc:cec5:c174:d88%2510]:20/go-gitea/gitea.git
panic: runtime error: invalid memory address or nil pointer dereference [recovered, repanicked]
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0x96055d]

This %10 is a scope id, maybe it's confusing the parser? In any case, the code should not segfault on it.

@wxiaoguang
Copy link
Contributor

The IPv6 address fe80:14fc:cec5:c174:d88 is invalid

@silverwind
Copy link
Member

Right, only 6 numbers any no ::, so yes that is not a valid IPv6 address.

@silverwind
Copy link
Member

Looks like those tests were added in ce3dd04, I wonder why it starts to fail now.

@wxiaoguang
Copy link
Contributor

Because Golang fixed their IPv6 parsing bug golang/go@9fd3ac8

@silverwind
Copy link
Member

Seems odd that they do such changes in a patch release. Anyways, we need to fix these tests.

@wxiaoguang
Copy link
Contributor

Because it is considered as a security fix.

@silverwind silverwind mentioned this pull request Oct 15, 2025
Merged
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 15, 2025
@lunny lunny mentioned this pull request Oct 15, 2025
Merged
@silverwind
Copy link
Member

silverwind commented Oct 15, 2025 •
edited
Loading

The fix must be backported as well because it's also failing on the 1.25 branch, so a standalone backportable PR might be nice.

Edit: ah I see you did already.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 15, 2025
silverwind pushed a commit that referenced this pull request Oct 15, 2025
@lunny
Fix build (#35669)
935f5e0 
backport #35656
lunny added a commit to lunny/gitea that referenced this pull request Oct 15, 2025
@lunny
Fix build (go-gitea#35669)
591cbf9 
backport go-gitea#35656
@lunny lunny mentioned this pull request Oct 15, 2025
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Oct 15, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 15, 2025
@silverwind silverwind merged commit 1bdb0b7 into go-gitea:main Oct 15, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Oct 15, 2025
silverwind pushed a commit that referenced this pull request Oct 15, 2025
@lunny
Fix build (#35674)
1644b87 
backport #35656
@lunny lunny deleted the lunny/upgrade_1.25.3 branch October 15, 2025 17:12
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 16, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c2a80d6 
* giteaofficial/main:
  Bump happy-dom from 20.0.0 to 20.0.2 (go-gitea#35677)
  Fix missing Close when error occurs and abused connection pool (go-gitea#35658)
  Upgrade to go 1.25.3 (go-gitea#35656)
  Always create Actions logs stepsContainer (go-gitea#35654)
  Fix a bug missed return (go-gitea#35655)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@silverwind silverwind silverwind approved these changes

+1 more reviewer

@TheFox0x7 TheFox0x7 TheFox0x7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code

Projects

None yet

Milestone

1.26.0

Development

Successfully merging this pull request may close these issues.

5 participants

@lunny @silverwind @wxiaoguang @TheFox0x7 @GiteaBot