Skip to content

Conversation

@zorrobiwan
Copy link
Contributor

Test was wrong and preventing update of force push allow users list by the API

Resolves #35893

Test was wrong and preventing update of force push allow users list by the API

Signed-off-by: Alberty Pascal <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 7, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 7, 2025
@zorrobiwan zorrobiwan changed the title Change ForcePushAllowlistDeployKeys to forcePushAllowlistUsers Change ForcePushAllowlistDeployKeys to forcePushAllowlistUsers in test to allow force push allowlist users to be modified by API Nov 7, 2025
@lunny
Copy link
Member

lunny commented Nov 7, 2025

Thank you for the contribution. It's better to have a test for that.

@delvh delvh changed the title Change ForcePushAllowlistDeployKeys to forcePushAllowlistUsers in test to allow force push allowlist users to be modified by API Use correct form field for allowed force push users in API Nov 8, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 8, 2025
@delvh delvh changed the title Use correct form field for allowed force push users in API Use correct form field for allowed force push users in branch protection API Nov 8, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 8, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 9, 2025
@lunny lunny enabled auto-merge (squash) November 9, 2025 20:54
@lunny lunny merged commit c4c4cf5 into go-gitea:main Nov 9, 2025
25 checks passed
@GiteaBot GiteaBot added this to the 1.26.0 milestone Nov 9, 2025
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Nov 9, 2025
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Nov 9, 2025
…ion API (go-gitea#35894)

Test was wrong and preventing update of force push allow users list by
the API

Resolves go-gitea#35893

Signed-off-by: Alberty Pascal <[email protected]>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/done All backports for this PR have been created backport/v1.25 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Force Push Allowlist users can't be updated by API

5 participants