fix: join and select mytable.* not working #6761

StephanoGeorge · 2023-12-21T09:30:17Z

Fixes bug:

Code:

db.InnerJoins("User.Company", db.Select("User__Company.*")).Take(&order)

Expected:

SELECT order.id, order.time, ..., User__Company.id, User__Company.name, User_Company... FROM ...

Actually before:

SELECT order.id, order.time, order... FROM

jinzhu · 2023-12-22T06:40:23Z

Could you please add some additional tests to help prevent future breaks? Thank you.

feat: increase readability of code matching table name column name

StephanoGeorge · 2023-12-22T08:24:56Z

@jinzhu Sure, already done, and also made some improvements

fix: select mytable.* not working

82ae136

fix: select mytable.*: will not match mytable."*".

bcd8aef

feat: increase readability of code matching table name column name

jinzhu merged commit 436cca7 into go-gorm:master Dec 23, 2023
34 checks passed

StephanoGeorge deleted the fix-select-star branch December 25, 2023 01:49

Provide feedback