Skip to content
This repository has been archived by the owner on May 11, 2020. It is now read-only.

wasm: implement imports #44

Merged
merged 3 commits into from
Dec 14, 2017
Merged

wasm: implement imports #44

merged 3 commits into from
Dec 14, 2017

Conversation

sbinet
Copy link
Contributor

@sbinet sbinet commented Dec 13, 2017

Updates #40.


This change is Reviewable

@sbinet sbinet requested a review from vibhavp December 13, 2017 17:13
@vibhavp
Copy link
Collaborator

vibhavp commented Dec 14, 2017

:lgtm:

In the future, we could allow wasm.Module to have Go-native functions and variables.


Review status: 0 of 5 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@sbinet
Copy link
Contributor Author

sbinet commented Dec 14, 2017

yep, that would be great :)
(so the last step of my advent-2017 blog post could be done in pure Go instead of a web server executing that wasm module or reaching for nodejs to do the same...)

@sbinet sbinet merged commit 6c2b2ee into master Dec 14, 2017
@sbinet sbinet deleted the wasm-import-support branch December 14, 2017 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants