Handle string option for time types similar to other types #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WARNING: This commit includes breaking changes. Previously, if StringifyNumbers was specified, we would permit unmarshaling of a JSON number into a Go number. However, this is not how the v1 equivalent functionality operated. In v1, once the `string` tag option was specified, it would only unmarshal a JSON string containing a JSON number, but would reject a JSON number. In #60, we made v2 more consistent with v1 for regular numeric types, but forgot to do so for time.Duration as well. Also, in #91, we no longer specify StringifyNumbers for map keys and expect a type to check the JSON state machine to handle object names specially. Do the same for time.Duration and time.Time.
johanbrandhorst
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WARNING: This commit includes breaking changes.
Previously, if StringifyNumbers was specified,
we would permit unmarshaling of a JSON number into a Go number. However, this is not how the v1 equivalent functionality operated. In v1, once the
stringtag option was specified, it would only unmarshal a JSON string containing a JSON number, but would reject a JSON number.In #60, we made v2 more consistent with v1 for regular numeric types, but forgot to do so for time.Duration as well.
Also, in #91, we no longer specify StringifyNumbers for map keys and expect a type to check the JSON state machine to handle object names specially. Do the same for time.Duration and time.Time.