Skip to content

Add favicon and comment #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yaojingguo
Copy link

  1. If favicon is missing, Chrome and Firefox still insist on finding it.
  2. Add comment clarifying the use of ReturnUri session value.

1. If favicon is missing, Chrome and Firefox still insist on finding it.
2. Add comment clarifying the use of ReturnUri session value.
@codecov-io
Copy link

Codecov Report

Merging #146 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   56.37%   56.37%           
=======================================
  Files          11       11           
  Lines         800      800           
=======================================
  Hits          451      451           
  Misses        244      244           
  Partials      105      105           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f942a4...5266590. Read the comment docs.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.37%. Comparing base (6f942a4) to head (5266590).
⚠️ Report is 104 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #146   +/-   ##
=======================================
  Coverage   56.37%   56.37%           
=======================================
  Files          11       11           
  Lines         800      800           
=======================================
  Hits          451      451           
  Misses        244      244           
  Partials      105      105           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants