Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new instance of the struct type for scanjsonvalue #1979 #1984

Open
wants to merge 1 commit into
base: v10
Choose a base branch
from

Conversation

Slitherings
Copy link

First pull request, wasn't able to test or make sure but this code looks like a fix towards the Scan JSON value get panic #1979
issue (not sure about the "return nil" code on 269) but aside from that hopefully this can be a step towards fixing this issue, but I saw this as a good time to push a potential fix since pg is in the process of migrating to Bun.

@elliotcourant
Copy link
Collaborator

I kind of dropped the ball on that issue and never looped back to it sorry. I can take a closer look at this code locally soon and see if I can come up with a test or point you in a direction for a test.

@elliotcourant elliotcourant self-requested a review September 14, 2023 21:43
@Slitherings
Copy link
Author

I kind of dropped the ball on that issue and never looped back to it sorry. I can take a closer look at this code locally soon and see if I can come up with a test or point you in a direction for a test.

All good, keep me posted just trying to help!

@elliotcourant
Copy link
Collaborator

@Slitherings is there a unit test to support this change?

@elliotcourant
Copy link
Collaborator

Sorry pushing all the wrong buttons, I need to figure out how to get this tested. Ideally we should have a unit test that would have failed before this patch but passes with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants