Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmarks to v1 and v2 #13

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Add benchmarks to v1 and v2 #13

merged 1 commit into from
Jul 30, 2024

Conversation

paskal
Copy link
Collaborator

@paskal paskal commented Jun 22, 2024

Was asked about performance and surprisingly found that v2 and v3 are faster than v1 due to generics usage.

@paskal paskal requested a review from umputun June 22, 2024 14:42
@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9626254555

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7979726215: 0.0%
Covered Lines: 159
Relevant Lines: 159
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9626315505

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7979726215: 0.0%
Covered Lines: 166
Relevant Lines: 166
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9626315508

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7979726215: 0.0%
Covered Lines: 159
Relevant Lines: 159
💛 - Coveralls

@coveralls
Copy link

coveralls commented Jun 22, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9626315507

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 7979726215: 0.0%
Covered Lines: 225
Relevant Lines: 225
💛 - Coveralls

@umputun umputun merged commit 2730a33 into master Jul 30, 2024
8 checks passed
@umputun umputun deleted the paskal/benchmarks branch July 30, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@umputun umputun Awaiting requested review from umputun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@paskal @coveralls @umputun