Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Fixes #907 (and possibly others?)
At first I found it weird that the
required_if
affected the behavior of thegte
tag, but after some debugging it seems that the conditionrunValidationWhenNil
is not checked for each field tag, but only for the first one.In this case it was set to true for the
required_if
tag, but set to false forgte
, so when therequired_if
preceded thegte
tag it meant that the field was incorrectly validated throughgte
even when it was nil.Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers