Add Chinese code platform gitee webhooks #147
Conversation
|
It seems to be a lint-tool issue |
gitee/payload.go
Outdated
| ) | ||
|
|
||
| type CommentEventPayload struct { | ||
| Action *string `json:"action,omitempty"` |
There was a problem hiding this comment.
Just to be sure, do we actually need use pointers everywhere?
Probably sometimes it make sense to have simple types as is. Or you should distinguish empty string and nil?
There was a problem hiding this comment.
BTW, you can generally omit "omitempty" for "incoming" types. You will use full structure anyway. It's more make sense for instantiating JSONs.
There was a problem hiding this comment.
BTW, you can generally omit "omitempty" for "incoming" types. You will use full structure anyway. It's more make sense for instantiating JSONs.
Thanks, I'll make some improvements and then retest it.
gitee/payload.go
Outdated
| Before *string `json:"before,omitempty"` | ||
| After *string `json:"after,omitempty"` | ||
| TotalCommitsCount int64 `json:"total_commits_count,omitempty"` | ||
| CommitsMoreThanTen *bool `json:"commits_more_than_ten,omitempty"` |
There was a problem hiding this comment.
The same thing about bool! Do we actually need to distinguish false and nil everywhere?
gitee/payload.go
Outdated
|
|
||
| // LabelHook : Label, issue and pull request labels | ||
| type LabelHook struct { | ||
| Id int32 `json:"id,omitempty"` |
There was a problem hiding this comment.
Interesting thing! Sometimes you use int32, but sometimes int64. Does it make sense to have different types for IDs?
It should be good to investigate it. May be run linter locally. Are you sure, that linter pass successful? |
|
The lint tool shows this, I don't know if there's something wrong with it. I test all the code on my own server, all the check items are pass. |
I'm a little bit busy right now, but will be able to investigate it in 1-2 weeks. Can you try, pls, the following: update linter version to the latest one (1.45.2). It's here: |
@Toshik1978 Thanks for remind me that. I will try to fix it. |
No description provided.