Skip to content

Commit

Permalink
update chromium revision
Browse files Browse the repository at this point in the history
  • Loading branch information
ysmood committed May 1, 2023
1 parent 2c73eec commit 763929b
Show file tree
Hide file tree
Showing 4 changed files with 22 additions and 7 deletions.
4 changes: 2 additions & 2 deletions lib/launcher/revision.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
package launcher

// RevisionDefault for chromium
const RevisionDefault = 1124540
const RevisionDefault = 1131003

// RevisionPlaywright for arm linux
const RevisionPlaywright = 1055
const RevisionPlaywright = 1060
20 changes: 17 additions & 3 deletions lib/proto/audits.go
Original file line number Diff line number Diff line change
Expand Up @@ -549,9 +549,6 @@ const (
// AuditsAttributionReportingIssueTypeInvalidEligibleHeader enum const
AuditsAttributionReportingIssueTypeInvalidEligibleHeader AuditsAttributionReportingIssueType = "InvalidEligibleHeader"

// AuditsAttributionReportingIssueTypeTooManyConcurrentRequests enum const
AuditsAttributionReportingIssueTypeTooManyConcurrentRequests AuditsAttributionReportingIssueType = "TooManyConcurrentRequests"

// AuditsAttributionReportingIssueTypeSourceAndTriggerHeaders enum const
AuditsAttributionReportingIssueTypeSourceAndTriggerHeaders AuditsAttributionReportingIssueType = "SourceAndTriggerHeaders"

Expand Down Expand Up @@ -693,6 +690,17 @@ type AuditsDeprecationIssueDetails struct {
Type string `json:"type"`
}

// AuditsBounceTrackingIssueDetails This issue warns about sites in the redirect chain of a finished navigation
// that may be flagged as trackers and have their state cleared if they don't
// receive a user interaction. Note that in this context 'site' means eTLD+1.
// For example, if the URL `https://example.test:80/bounce` was in the
// redirect chain, the site reported would be `example.test`.
type AuditsBounceTrackingIssueDetails struct {

// TrackingSites ...
TrackingSites []string `json:"trackingSites"`
}

// AuditsClientHintIssueReason ...
type AuditsClientHintIssueReason string

Expand Down Expand Up @@ -867,6 +875,9 @@ const (

// AuditsInspectorIssueCodeFederatedAuthRequestIssue enum const
AuditsInspectorIssueCodeFederatedAuthRequestIssue AuditsInspectorIssueCode = "FederatedAuthRequestIssue"

// AuditsInspectorIssueCodeBounceTrackingIssue enum const
AuditsInspectorIssueCodeBounceTrackingIssue AuditsInspectorIssueCode = "BounceTrackingIssue"
)

// AuditsInspectorIssueDetails This struct holds a list of optional fields with additional information
Expand Down Expand Up @@ -921,6 +932,9 @@ type AuditsInspectorIssueDetails struct {

// FederatedAuthRequestIssueDetails (optional) ...
FederatedAuthRequestIssueDetails *AuditsFederatedAuthRequestIssueDetails `json:"federatedAuthRequestIssueDetails,omitempty"`

// BounceTrackingIssueDetails (optional) ...
BounceTrackingIssueDetails *AuditsBounceTrackingIssueDetails `json:"bounceTrackingIssueDetails,omitempty"`
}

// AuditsIssueID A unique id for a DevTools inspector issue. Allows other entities (e.g.
Expand Down
4 changes: 2 additions & 2 deletions lib/proto/css.go
Original file line number Diff line number Diff line change
Expand Up @@ -538,8 +538,8 @@ type CSSCSSTryRule struct {
// Origin Parent stylesheet's origin.
Origin CSSStyleSheetOrigin `json:"origin"`

// Style (optional) Associated style declaration.
Style *CSSCSSStyle `json:"style,omitempty"`
// Style Associated style declaration.
Style *CSSCSSStyle `json:"style"`
}

// CSSCSSPositionFallbackRule CSS position-fallback rule representation.
Expand Down
1 change: 1 addition & 0 deletions lib/proto/definitions.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ var types = map[string]reflect.Type{
"Audits.NavigatorUserAgentIssueDetails": reflect.TypeOf(AuditsNavigatorUserAgentIssueDetails{}),
"Audits.GenericIssueDetails": reflect.TypeOf(AuditsGenericIssueDetails{}),
"Audits.DeprecationIssueDetails": reflect.TypeOf(AuditsDeprecationIssueDetails{}),
"Audits.BounceTrackingIssueDetails": reflect.TypeOf(AuditsBounceTrackingIssueDetails{}),
"Audits.FederatedAuthRequestIssueDetails": reflect.TypeOf(AuditsFederatedAuthRequestIssueDetails{}),
"Audits.ClientHintIssueDetails": reflect.TypeOf(AuditsClientHintIssueDetails{}),
"Audits.InspectorIssueDetails": reflect.TypeOf(AuditsInspectorIssueDetails{}),
Expand Down

0 comments on commit 763929b

Please sign in to comment.