Build for chromium #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmartingr
reviewed
Jan 5, 2025
Makefile
Outdated
| jq 'del(.background.scripts) | del(.browser_specific_settings) | .background += {service_worker: "js/service-worker.js"}' manifest.json > shiori-chromium/manifest.json | ||
| echo "importScripts('browser-polyfill.js', 'background-script.js');" > shiori-chromium/js/service-worker.js | ||
| sed -i 's#icons#/icons#g' shiori-chromium/js/background-script.js | ||
| web-ext build -s shiori-chromium -a dist |
There was a problem hiding this comment.
Maybe is better to build the chromium extension under a different directory?
Suggested change
| web-ext build -s shiori-chromium -a dist | |
| web-ext build -s shiori-chromium -a dist-chromium |
There was a problem hiding this comment.
Certainly, the zip filenames are the same, so using different directories would be better
fmartingr
force-pushed
the
master
branch
2 times, most recently
from
d548a63 to
ad84d3e
Compare
fmartingr
approved these changes
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the mozilla/web-ext#2653 (comment), modified the Makefile to build a chromium extension.
Solve #23