fix: temporary files not being deleted

[Oppen]

Fixes a path mismatch between a temporary file and its removal.
It also fixes a second removal of the file.

Should fix #966

[Monirzadeh]

we try to remove os package and handle things with abstract layer can you find why abstract layer not working?

[Oppen]

The reason is the FS domain assumes everything is relative to the data dir, while the temporary file is relative to the root directory. Why are we using the abstraction? Doesn't the os package work well enough?
Fixing it under the abstraction would require bigger changes to the domains module I believe. Not against it but I can't commit to do it myself right now.

[fmartingr]

As I said in #966, this should be in in order to fix the problem. i don't think we need any more changes for now in order to work with ephemeral files.

[Monirzadeh]

it is good to have an issue or something in road map to review all the abstraction layer to fix in that level later. @Oppen can you review that when ever you have free time?
any way thanks for investigation and PR.
as i see windows test pass for now so no problem in my side

[Oppen]

it is good to have an issue or something in road map to review all the abstraction layer to fix in that level later. @Oppen can you review that when ever you have free time?

Sure!

any way thanks for investigation and PR. as i see windows test pass for now so no problem in my side
❤️