Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: composable type & map[string]any #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xyedo
Copy link

@Xyedo Xyedo commented Jul 8, 2024

Hi! my PR composes 2 part:

  1. added composable by using "allOf"
  2. added inline response when using map[string]any

and it will closes this #25 issue

List of API that breaking:

  1. endpoints.JsonResponse: from JsonResponseSchema to JsonResponseSchemaAllOf
  2. parsing.Type(): the function then receive string, now reflect.Type
  3. response.Generate(): from JsonResponseSchema now returning parameter.JsonResponseSchemaAllOf:
  4. parameter.JsonParameter: Schema fields now JsonResponseSchemaAllOf

Why Breaking:

  1. needed for composable type
  2. i prefer it that way, but i can introduce TypeWithReflect without making it breaking
  3. needed for composable type
  4. needed for composable type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant