Skip to content

Commit

Permalink
rename error
Browse files Browse the repository at this point in the history
  • Loading branch information
vmaerten committed Feb 10, 2025
1 parent 22d308f commit 509afa8
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
14 changes: 7 additions & 7 deletions errors/errors_task.go
Original file line number Diff line number Diff line change
Expand Up @@ -141,13 +141,13 @@ func (err *TaskCancelledNoTerminalError) Code() int {
return CodeTaskCancelled
}

// TaskMissingRequiredVars is returned when a task is missing required variables.
// TaskMissingRequiredVarsError is returned when a task is missing required variables.

type MissingVar struct {
Name string
AllowedValues []string
}
type TaskMissingRequiredVars struct {
type TaskMissingRequiredVarsError struct {
TaskName string
MissingVars []MissingVar
}
Expand All @@ -159,7 +159,7 @@ func (v MissingVar) String() string {
return fmt.Sprintf("%s (allowed values: %v)", v.Name, v.AllowedValues)
}

func (err *TaskMissingRequiredVars) Error() string {
func (err *TaskMissingRequiredVarsError) Error() string {
var vars []string
for _, v := range err.MissingVars {
vars = append(vars, v.String())
Expand All @@ -171,7 +171,7 @@ func (err *TaskMissingRequiredVars) Error() string {
strings.Join(vars, ", "))
}

func (err *TaskMissingRequiredVars) Code() int {
func (err *TaskMissingRequiredVarsError) Code() int {
return CodeTaskMissingRequiredVars
}

Expand All @@ -181,12 +181,12 @@ type NotAllowedVar struct {
Name string
}

type TaskNotAllowedVars struct {
type TaskNotAllowedVarsError struct {
TaskName string
NotAllowedVars []NotAllowedVar
}

func (err *TaskNotAllowedVars) Error() string {
func (err *TaskNotAllowedVarsError) Error() string {
var builder strings.Builder

builder.WriteString(fmt.Sprintf("task: Task %q cancelled because it is missing required variables:\n", err.TaskName))
Expand All @@ -197,6 +197,6 @@ func (err *TaskNotAllowedVars) Error() string {
return builder.String()
}

func (err *TaskNotAllowedVars) Code() int {
func (err *TaskNotAllowedVarsError) Code() int {
return CodeTaskNotAllowedVars
}
4 changes: 2 additions & 2 deletions requires.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ func (e *Executor) areTaskRequiredVarsSet(t *ast.Task) error {
}

if len(missingVars) > 0 {
return &errors.TaskMissingRequiredVars{
return &errors.TaskMissingRequiredVarsError{
TaskName: t.Name(),
MissingVars: missingVars,
}
Expand Down Expand Up @@ -54,7 +54,7 @@ func (e *Executor) areTaskRequiredVarsAllowedValuesSet(t *ast.Task) error {
}

if len(notAllowedValuesVars) > 0 {
return &errors.TaskNotAllowedVars{
return &errors.TaskNotAllowedVarsError{
TaskName: t.Name(),
NotAllowedVars: notAllowedValuesVars,
}
Expand Down

0 comments on commit 509afa8

Please sign in to comment.