Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: display allowed values when vars are not provided #2052

Merged
merged 5 commits into from
Feb 20, 2025
Merged

feat: display allowed values when vars are not provided #2052

merged 5 commits into from
Feb 20, 2025
+44 −18

Conversation

vmaerten
Copy link
Member

@vmaerten vmaerten commented Feb 9, 2025 •
edited
Loading

@vmaerten vmaerten self-assigned this Feb 9, 2025
@vmaerten vmaerten linked an issue Feb 9, 2025 that may be closed by this pull request
Show allowed values when variable with set enum is missing #2027
Closed
@vmaerten vmaerten marked this pull request as ready for review February 9, 2025 19:17
@vmaerten vmaerten requested review from andreynering and pd93 February 9, 2025 19:17
pd93
pd93 reviewed Feb 10, 2025
View reviewed changes
@vmaerten vmaerten requested a review from pd93 February 10, 2025 20:16
pd93
pd93 approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@pd93 pd93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmaerten vmaerten merged commit 35ea4e0 into main Feb 20, 2025
14 checks passed
@vmaerten vmaerten deleted the feat/add-allowed-values-when-vars-not-provided branch February 20, 2025 19:08
vmaerten added a commit that referenced this pull request Feb 20, 2025
@vmaerten
chore: changelog for #2052
fb27318
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pd93 pd93 pd93 approved these changes

@andreynering andreynering Awaiting requested review from andreynering

Assignees

@vmaerten vmaerten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show allowed values when variable with set enum is missing
2 participants
@vmaerten @pd93