Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump minimum version to 1.23 #2059

Merged
merged 3 commits into from
Feb 11, 2025
Merged

chore: bump minimum version to 1.23 #2059

merged 3 commits into from
Feb 11, 2025

Conversation

pd93
Copy link
Member

@pd93 pd93 commented Feb 11, 2025

Bumps the minimum Go version to v1.23. This allows us to start using 1.23 features in the next version of Task! Tests will now run on 1.23 and 1.24.

@pd93 pd93 marked this pull request as draft February 11, 2025 21:24
@pd93
Copy link
Member Author

pd93 commented Feb 11, 2025

Waiting for golangci/golangci-lint#5224 for the lint checks to pass.

Also seems that they have changed the way the versioning information works:

The go build command now sets the main module’s version in the compiled binary based on the version control system tag and/or commit. A +dirty suffix will be appended if there are uncommitted changes. Use the -buildvcs=false flag to omit version control information from the binary.

This actually appears to have broken one of our tests, but should be simple to fix.

@pd93 pd93 marked this pull request as ready for review February 11, 2025 22:42
@pd93 pd93 merged commit ce96447 into main Feb 11, 2025
14 checks passed
@pd93 pd93 deleted the 1.24 branch February 11, 2025 22:43
pd93 added a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant