Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change types to api types #336

Merged
merged 2 commits into from
Oct 11, 2024
Merged

chore: change types to api types #336

merged 2 commits into from
Oct 11, 2024

Conversation

ecrupper
Copy link
Contributor

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner October 11, 2024 18:55
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.63%. Comparing base (05703df) to head (b837863).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   89.63%   89.63%           
=======================================
  Files          22       22           
  Lines         878      878           
=======================================
  Hits          787      787           
  Misses         55       55           
  Partials       36       36           
Files with missing lines Coverage Δ
vela/admin.go 95.18% <100.00%> (ø)
vela/deployment.go 88.88% <100.00%> (ø)
vela/hook.go 92.85% <100.00%> (ø)
vela/pipeline.go 73.52% <100.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ecrupper ecrupper merged commit 7665967 into main Oct 11, 2024
9 of 11 checks passed
@ecrupper ecrupper deleted the chore/bump-server-4-types branch October 11, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants