chore: fixing code lint issues #11562
plyr4Annotations
43 errors
|
[golangci] queue/redis/redis_test.go#L95:
queue/redis/redis_test.go#L95
`_steps` is unused (deadcode)
|
|
[golangci] database/pipeline/create.go#L3:
database/pipeline/create.go#L3
3-53 lines are duplicate of `database/pipeline/update.go:3-54` (dupl)
|
|
[golangci] database/pipeline/update.go#L3:
database/pipeline/update.go#L3
3-54 lines are duplicate of `database/pipeline/create.go:3-53` (dupl)
|
|
[golangci] mock/server/schedule.go#L3:
mock/server/schedule.go#L3
3-211 lines are duplicate of `mock/server/secret.go:4-167` (dupl)
|
|
[golangci] compiler/native/expand.go#L48:
compiler/native/expand.go#L48
Function 'ExpandSteps' has too many statements (71 > 70) (funlen)
|
|
[golangci] cmd/vela-server/server.go#L26:
cmd/vela-server/server.go#L26
Function 'server' is too long (199 > 160) (funlen)
|
|
[golangci] mock/server/authentication.go#L41:
mock/server/authentication.go#L41
string `error` has 4 occurrences, make it a constant (goconst)
|
|
[golangci] compiler/registry/github/github.go#L41:
compiler/registry/github/github.go#L41
string `/api/v3/` has 5 occurrences, make it a constant (goconst)
|
|
[golangci] queue/redis/ping_test.go#L8:
queue/redis/ping_test.go#L8
File is not `goimports`-ed (goimports)
|
|
[golangci] database/schedule/count.go#L6:
database/schedule/count.go#L6
File is not `goimports`-ed (goimports)
|
|
[golangci] database/schedule/count_active.go#L6:
database/schedule/count_active.go#L6
File is not `goimports`-ed (goimports)
|
|
[golangci] queue/redis/route_test.go#L62:
queue/redis/route_test.go#L62
G601: Implicit memory aliasing in for loop. (gosec)
|
|
[golangci] compiler/native/compile_test.go#L1818:
compiler/native/compile_test.go#L1818
G601: Implicit memory aliasing in for loop. (gosec)
|
|
[golangci] compiler/native/compile_test.go#L3129:
compiler/native/compile_test.go#L3129
G601: Implicit memory aliasing in for loop. (gosec)
|
|
[golangci] cmd/vela-server/schedule.go#L106:
cmd/vela-server/schedule.go#L106
`occurence` is a misspelling of `occurrence` (misspell)
|
|
[golangci] database/user/create.go#L17:
database/user/create.go#L17
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] database/user/table.go#L48:
database/user/table.go#L48
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] database/user/delete.go#L15:
database/user/delete.go#L15
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] scm/github/authentication.go#L58:
scm/github/authentication.go#L58
unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] compiler/native/parse_test.go#L861:
compiler/native/parse_test.go#L861
unused-parameter: parameter 'p' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] router/middleware/logger.go#L42:
router/middleware/logger.go#L42
unused-parameter: parameter 'timeFormat' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] router/middleware/logger_test.go#L226:
router/middleware/logger_test.go#L226
unnecessary leading newline (whitespace)
|
|
[golangci] router/middleware/logger_test.go#L268:
router/middleware/logger_test.go#L268
unnecessary trailing newline (whitespace)
|
|
[golangci] api/schedule/update.go#L128:
api/schedule/update.go#L128
if statements should only be cuddled with assignments (wsl)
|
|
[golangci] router/middleware/logger.go#L187:
router/middleware/logger.go#L187
return statements should not be cuddled if block has more than two lines (wsl)
|
|
[golangci] cmd/vela-server/schedule.go#L280:
cmd/vela-server/schedule.go#L280
expressions should not be cuddled with blocks (wsl)
|
|
[golangci] api/webhook/post.go#L180:
api/webhook/post.go#L180
Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
|
|
[golangci] api/webhook/post.go#L749:
api/webhook/post.go#L749
Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
|
|
[golangci] api/webhook/post.go#L760:
api/webhook/post.go#L760
Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
|
|
[golangci] scm/github/access.go#L34:
scm/github/access.go#L34
Function `newClientToken` should pass the context parameter (contextcheck)
|
|
[golangci] scm/github/access.go#L70:
scm/github/access.go#L70
Function `newClientToken` should pass the context parameter (contextcheck)
|
|
[golangci] scm/github/access.go#L101:
scm/github/access.go#L101
Function `newClientToken` should pass the context parameter (contextcheck)
|
|
[golangci] database/schedule/create.go#L3:
database/schedule/create.go#L3
directive `//nolint:dupl // ignore similar code with update.go` is unused for linter "dupl" (nolintlint)
|
|
[golangci] compiler/native/compile.go#L264:
compiler/native/compile.go#L264
directive `//nolint:dupl,lll // linter thinks the steps and stages workflows are identical` is unused for linter "dupl" (nolintlint)
|
|
[golangci] compiler/native/compile.go#L361:
compiler/native/compile.go#L361
directive `//nolint:dupl,lll // linter thinks the steps and stages workflows are identical` is unused for linter "dupl" (nolintlint)
|
|
[golangci] api/admin/step.go#L3:
api/admin/step.go#L3
directive `//nolint:dupl // ignore similar code` is unused for linter "dupl" (nolintlint)
|
|
[golangci] secret/vault/count.go#L37:
secret/vault/count.go#L37
directive `//nolint:staticcheck // ignore false positive` is unused for linter "staticcheck" (nolintlint)
|
|
[golangci] secret/vault/get.go#L40:
secret/vault/get.go#L40
directive `//nolint:ineffassign,staticcheck // ignore false positive` is unused for linter "staticcheck" (nolintlint)
|
|
[golangci] secret/vault/list.go#L45:
secret/vault/list.go#L45
directive `//nolint:staticcheck // ignore false positive` is unused for linter "staticcheck" (nolintlint)
|
|
[golangci] api/secret/create.go#L79:
api/secret/create.go#L79
directive `//nolint:funlen // suppress long function error` is unused for linter "funlen" (nolintlint)
|
|
[golangci] api/build/create.go#L302:
api/build/create.go#L302
directive `//nolint:dupl // ignore duplicate code` is unused for linter "dupl" (nolintlint)
|
|
[golangci] api/build/restart.go#L294:
api/build/restart.go#L294
directive `//nolint:dupl // ignore duplicate code` is unused for linter "dupl" (nolintlint)
|
|
[golangci] api/build/skip.go#L12:
api/build/skip.go#L12
directive `//nolint:goconst // ignore init and clone constants` is unused for linter "goconst" (nolintlint)
|