fix(graph): use build.steps as source and add agressive nil checks #5075
plyr4reviewdog.yml
on: pull_request
diff-review
1m 44s
full-review
1m 38s
Annotations
20 errors
|
full-review:
queue/redis/redis_test.go#L95
`_steps` is unused (deadcode)
|
|
full-review:
mock/server/authentication.go#L41
string `error` has 4 occurrences, make it a constant (goconst)
|
|
full-review:
compiler/registry/github/github.go#L41
string `/api/v3/` has 5 occurrences, make it a constant (goconst)
|
|
full-review:
queue/redis/route_test.go#L62
G601: Implicit memory aliasing in for loop. (gosec)
|
|
full-review:
compiler/native/compile_test.go#L1818
G601: Implicit memory aliasing in for loop. (gosec)
|
|
full-review:
compiler/native/compile_test.go#L3129
G601: Implicit memory aliasing in for loop. (gosec)
|
|
full-review:
cmd/vela-server/schedule.go#L106
`occurence` is a misspelling of `occurrence` (misspell)
|
|
full-review:
database/worker/get.go#L14
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
database/worker/get_hostname.go#L15
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
full-review:
database/worker/update.go#L15
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
queue/redis/redis_test.go#L95
`_steps` is unused (deadcode)
|
|
diff-review:
mock/server/authentication.go#L41
string `error` has 4 occurrences, make it a constant (goconst)
|
|
diff-review:
compiler/registry/github/github.go#L41
string `/api/v3/` has 5 occurrences, make it a constant (goconst)
|
|
diff-review:
queue/redis/route_test.go#L62
G601: Implicit memory aliasing in for loop. (gosec)
|
|
diff-review:
compiler/native/compile_test.go#L1818
G601: Implicit memory aliasing in for loop. (gosec)
|
|
diff-review:
compiler/native/compile_test.go#L3129
G601: Implicit memory aliasing in for loop. (gosec)
|
|
diff-review:
cmd/vela-server/schedule.go#L106
`occurence` is a misspelling of `occurrence` (misspell)
|
|
diff-review:
database/schedule/count_repo.go#L13
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
database/schedule/create.go#L16
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
diff-review:
database/schedule/index.go#L19
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|