fix tests from latest merges to main #12897
ecrupperAnnotations
55 errors
|
[golangci] database/executable/pop.go#L15:
database/executable/pop.go#L15
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] database/executable/table.go#L38:
database/executable/table.go#L38
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] database/executable/create.go#L16:
database/executable/create.go#L16
unused-parameter: parameter 'ctx' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] cmd/vela-server/server.go#L26:
cmd/vela-server/server.go#L26
Function 'server' is too long (201 > 160) (funlen)
|
|
[golangci] cmd/vela-server/server.go#L162:
cmd/vela-server/server.go#L162
only one cuddle assignment allowed before if statement (wsl)
|
|
[golangci] cmd/vela-server/server.go#L165:
cmd/vela-server/server.go#L165
expressions should not be cuddled with blocks (wsl)
|
|
[golangci] cmd/vela-server/server.go#L172:
cmd/vela-server/server.go#L172
return statements should not be cuddled if block has more than two lines (wsl)
|
|
[golangci] cmd/vela-server/server.go#L193:
cmd/vela-server/server.go#L193
for statement without condition should never be cuddled (wsl)
|
|
[golangci] cmd/vela-server/server.go#L161:
cmd/vela-server/server.go#L161
assignments should only be cuddled with other assignments (wsl)
|
|
[golangci] cmd/vela-server/server.go#L168:
cmd/vela-server/server.go#L168
assignments should only be cuddled with other assignments (wsl)
|
|
[golangci] cmd/vela-server/server.go#L169:
cmd/vela-server/server.go#L169
only one cuddle assignment allowed before if statement (wsl)
|
|
[golangci] cmd/vela-server/server.go#L181:
cmd/vela-server/server.go#L181
assignments should only be cuddled with other assignments (wsl)
|
|
[golangci] cmd/vela-server/server.go#L182:
cmd/vela-server/server.go#L182
only one cuddle assignment allowed before if statement (wsl)
|
|
[golangci] router/middleware/logger.go#L42:
router/middleware/logger.go#L42
unused-parameter: parameter 'timeFormat' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] router/middleware/header.go#L33:
router/middleware/header.go#L33
if statements should only be cuddled with assignments (wsl)
|
|
[golangci] router/middleware/header.go#L37:
router/middleware/header.go#L37
expressions should not be cuddled with blocks (wsl)
|
|
[golangci] database/resource.go#L29:
database/resource.go#L29
Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
|
|
[golangci] database/resource.go#L40:
database/resource.go#L40
Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
|
|
[golangci] database/resource.go#L53:
database/resource.go#L53
Non-inherited new context, use function like `context.WithXXX` instead (contextcheck)
|
|
[golangci] database/worker/create.go#L3:
database/worker/create.go#L3
3-36 lines are duplicate of `database/worker/update.go:3-36` (dupl)
|
|
[golangci] database/worker/update.go#L3:
database/worker/update.go#L3
3-36 lines are duplicate of `database/worker/create.go:3-36` (dupl)
|
|
[golangci] database/step/count.go#L6:
database/step/count.go#L6
File is not `goimports`-ed (goimports)
|
|
[golangci] database/step/count_build.go#L6:
database/step/count_build.go#L6
File is not `goimports`-ed (goimports)
|
|
[golangci] database/step/create.go#L6:
database/step/create.go#L6
File is not `goimports`-ed (goimports)
|
|
[golangci] database/deployment/create.go#L3:
database/deployment/create.go#L3
3-33 lines are duplicate of `database/deployment/update.go:3-32` (dupl)
|
|
[golangci] database/deployment/update.go#L3:
database/deployment/update.go#L3
3-32 lines are duplicate of `database/deployment/create.go:3-33` (dupl)
|
|
[golangci] database/pipeline/create.go#L3:
database/pipeline/create.go#L3
3-53 lines are duplicate of `database/pipeline/update.go:3-54` (dupl)
|
|
[golangci] database/pipeline/update.go#L3:
database/pipeline/update.go#L3
3-54 lines are duplicate of `database/pipeline/create.go:3-53` (dupl)
|
|
[golangci] api/repo/create.go#L198:
api/repo/create.go#L198
expressions should not be cuddled with blocks (wsl)
|
|
[golangci] scm/github/authentication.go#L58:
scm/github/authentication.go#L58
unused-parameter: parameter 'w' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] scm/github/access.go#L34:
scm/github/access.go#L34
Function `newClientToken` should pass the context parameter (contextcheck)
|
|
[golangci] scm/github/access.go#L103:
scm/github/access.go#L103
Function `newClientToken` should pass the context parameter (contextcheck)
|
|
[golangci] scm/github/access.go#L153:
scm/github/access.go#L153
Function `newClientToken` should pass the context parameter (contextcheck)
|
|
[golangci] scm/github/repo.go#L527:
scm/github/repo.go#L527
SA1019: client.Repositories.List is deprecated: Use RepositoriesService.ListByUser or RepositoriesService.ListByAuthenticatedUser instead. (staticcheck)
|
|
[golangci] api/pipeline/validate.go#L70:
api/pipeline/validate.go#L70
70-109 lines are duplicate of `api/pipeline/compile.go:73-112` (dupl)
|
|
[golangci] secret/vault/refresh_test.go#L45:
secret/vault/refresh_test.go#L45
unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] secret/vault/refresh_test.go#L71:
secret/vault/refresh_test.go#L71
unused-parameter: parameter 'in' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] secret/vault/refresh_test.go#L108:
secret/vault/refresh_test.go#L108
unused-parameter: parameter 'in' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] secret/vault/refresh_test.go#L128:
secret/vault/refresh_test.go#L128
unused-parameter: parameter 'in' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] secret/vault/refresh_test.go#L201:
secret/vault/refresh_test.go#L201
unused-parameter: parameter 'r' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] queue/redis/route_test.go#L62:
queue/redis/route_test.go#L62
G601: Implicit memory aliasing in for loop. (gosec)
|
|
[golangci] queue/redis/redis_test.go#L91:
queue/redis/redis_test.go#L91
var `_steps` is unused (unused)
|
|
[golangci] mock/server/schedule.go#L3:
mock/server/schedule.go#L3
3-142 lines are duplicate of `mock/server/secret.go:4-180` (dupl)
|
|
[golangci] mock/server/authentication.go#L41:
mock/server/authentication.go#L41
string `error` has 4 occurrences, make it a constant (goconst)
|
|
[golangci] compiler/native/expand.go#L48:
compiler/native/expand.go#L48
Function 'ExpandSteps' has too many statements (74 > 70) (funlen)
|
|
[golangci] compiler/native/compile_test.go#L1818:
compiler/native/compile_test.go#L1818
G601: Implicit memory aliasing in for loop. (gosec)
|
|
[golangci] compiler/native/compile_test.go#L2967:
compiler/native/compile_test.go#L2967
G601: Implicit memory aliasing in for loop. (gosec)
|
|
[golangci] compiler/native/parse_test.go#L861:
compiler/native/parse_test.go#L861
unused-parameter: parameter 'p' seems to be unused, consider removing or renaming it as _ (revive)
|
|
[golangci] database/schedule/create.go#L3:
database/schedule/create.go#L3
directive `//nolint:dupl // ignore similar code with update.go` is unused for linter "dupl" (nolintlint)
|
|
[golangci] api/build/skip.go#L12:
api/build/skip.go#L12
directive `//nolint:goconst // ignore init and clone constants` is unused for linter "goconst" (nolintlint)
|
|
[golangci] secret/vault/count.go#L37:
secret/vault/count.go#L37
directive `//nolint:staticcheck // ignore false positive` is unused for linter "staticcheck" (nolintlint)
|
|
[golangci] secret/vault/get.go#L40:
secret/vault/get.go#L40
directive `//nolint:ineffassign,staticcheck // ignore false positive` is unused for linter "staticcheck" (nolintlint)
|
|
[golangci] secret/vault/list.go#L45:
secret/vault/list.go#L45
directive `//nolint:staticcheck // ignore false positive` is unused for linter "staticcheck" (nolintlint)
|
|
[golangci] compiler/native/compile.go#L302:
compiler/native/compile.go#L302
directive `//nolint:dupl,lll // linter thinks the steps and stages workflows are identical` is unused for linter "dupl" (nolintlint)
|
|
[golangci] compiler/native/compile.go#L399:
compiler/native/compile.go#L399
directive `//nolint:dupl,lll // linter thinks the steps and stages workflows are identical` is unused for linter "dupl" (nolintlint)
|