fix: add err check to ParseBool

go-vela · May 30, 2024 · 169b103 · 169b103
1 parent 0699f60
commit 169b103
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/api/build/id_request_token.go b/api/build/id_request_token.go
@@ -96,7 +96,14 @@ func GetIDRequestToken(c *gin.Context) {
 
 	image := c.Query("image")
 	request := c.Query("request")
-	commands, _ := strconv.ParseBool(c.Query("commands"))
+	commands, err := strconv.ParseBool(c.Query("commands"))
+	if err != nil {
+		retErr := fmt.Errorf("unable to parse 'commands' query %s: %w", c.Query("commands"), err)
+
+		util.HandleError(c, http.StatusBadRequest, retErr)
+
+		return
+	}
 
 	// retrieve token manager from context
 	tm := c.MustGet("token-manager").(*token.Manager)