chore: fixing code lint issues (#999)

go-vela · Nov 3, 2023 · 542c244 · 542c244
1 parent 32bd680
commit 542c244
Show file tree

Hide file tree

Showing 26 changed files with 102 additions and 98 deletions.
diff --git a/api/build/graph.go b/api/build/graph.go
@@ -131,7 +131,7 @@ const (
 // GetBuildGraph represents the API handler to capture a
 // directed a-cyclical graph for a build from the configured backend.
 //
-//nolint:funlen,goconst // ignore function length and constants
+//nolint:funlen,goconst,gocyclo // ignore function length and constants
 func GetBuildGraph(c *gin.Context) {
 	// capture middleware values
 	b := build.Retrieve(c)
@@ -425,6 +425,7 @@ func GetBuildGraph(c *gin.Context) {
 		if stage.Name == "init" {
 			cluster = BuiltInCluster
 		}
+
 		if stage.Name == "clone" {
 			cluster = BuiltInCluster
 		}

diff --git a/api/metrics.go b/api/metrics.go
@@ -442,7 +442,6 @@ func recordGauges(c *gin.Context) {
 			}
 			// check if the worker checked in within the last worker_active_interval
 			if worker.GetLastCheckedIn() >= before {
-
 				switch worker.GetStatus() {
 				case constants.WorkerStatusIdle:
 					idleWorkers++

diff --git a/database/build/build_test.go b/database/build/build_test.go
@@ -268,7 +268,7 @@ func testRepo() *library.Repo {
 type AnyArgument struct{}
 
 // Match satisfies sqlmock.Argument interface.
-func (a AnyArgument) Match(v driver.Value) bool {
+func (a AnyArgument) Match(_ driver.Value) bool {
 	return true
 }
 

diff --git a/database/database.go b/database/database.go
@@ -80,6 +80,7 @@ type (
 //
 // * postgres
 // * sqlite3
+// .
 func New(opts ...EngineOpt) (Interface, error) {
 	// create new database engine
 	e := new(engine)

diff --git a/database/log/log_test.go b/database/log/log_test.go
@@ -174,7 +174,7 @@ func testSqlite(t *testing.T) *engine {
 type AnyArgument struct{}
 
 // Match satisfies sqlmock.Argument interface.
-func (a AnyArgument) Match(v driver.Value) bool {
+func (a AnyArgument) Match(_ driver.Value) bool {
 	return true
 }
 

diff --git a/database/pipeline/pipeline_test.go b/database/pipeline/pipeline_test.go
@@ -204,6 +204,6 @@ func testPipeline() *library.Pipeline {
 type AnyArgument struct{}
 
 // Match satisfies sqlmock.Argument interface.
-func (a AnyArgument) Match(v driver.Value) bool {
+func (a AnyArgument) Match(_ driver.Value) bool {
 	return true
 }
diff --git a/database/repo/repo_test.go b/database/repo/repo_test.go
@@ -208,6 +208,6 @@ func testRepo() *library.Repo {
 type AnyArgument struct{}
 
 // Match satisfies sqlmock.Argument interface.
-func (a AnyArgument) Match(v driver.Value) bool {
+func (a AnyArgument) Match(_ driver.Value) bool {
 	return true
 }
diff --git a/database/user/user_test.go b/database/user/user_test.go
@@ -193,6 +193,6 @@ func testUser() *library.User {
 type AnyArgument struct{}
 
 // Match satisfies sqlmock.Argument interface.
-func (a AnyArgument) Match(v driver.Value) bool {
+func (a AnyArgument) Match(_ driver.Value) bool {
 	return true
 }
diff --git a/internal/token/refresh_test.go b/internal/token/refresh_test.go
@@ -51,7 +51,7 @@ func TestTokenManager_Refresh(t *testing.T) {
 	}
 
 	defer func() {
-		db.DeleteUser(context.TODO(), u)
+		_ = db.DeleteUser(context.TODO(), u)
 		db.Close()
 	}()
 
@@ -112,7 +112,7 @@ func TestTokenManager_Refresh_Expired(t *testing.T) {
 	}
 
 	defer func() {
-		db.DeleteUser(context.TODO(), u)
+		_ = db.DeleteUser(context.TODO(), u)
 		db.Close()
 	}()
 

diff --git a/router/middleware/build/build_test.go b/router/middleware/build/build_test.go
@@ -88,8 +88,8 @@ func TestBuild_Establish(t *testing.T) {
 	}
 
 	defer func() {
-		db.DeleteBuild(context.TODO(), want)
-		db.DeleteRepo(context.TODO(), r)
+		_ = db.DeleteBuild(context.TODO(), want)
+		_ = db.DeleteRepo(context.TODO(), r)
 		db.Close()
 	}()
 
@@ -171,7 +171,7 @@ func TestBuild_Establish_NoBuildParameter(t *testing.T) {
 	}
 
 	defer func() {
-		db.DeleteRepo(context.TODO(), r)
+		_ = db.DeleteRepo(context.TODO(), r)
 		db.Close()
 	}()
 
@@ -219,7 +219,7 @@ func TestBuild_Establish_InvalidBuildParameter(t *testing.T) {
 	}
 
 	defer func() {
-		db.DeleteRepo(context.TODO(), r)
+		_ = db.DeleteRepo(context.TODO(), r)
 		db.Close()
 	}()
 
@@ -267,7 +267,7 @@ func TestBuild_Establish_NoBuild(t *testing.T) {
 	}
 
 	defer func() {
-		db.DeleteRepo(context.TODO(), r)
+		_ = db.DeleteRepo(context.TODO(), r)
 		db.Close()
 	}()
 

diff --git a/router/middleware/claims/claims_test.go b/router/middleware/claims/claims_test.go
@@ -273,7 +273,7 @@ func TestClaims_Establish_BadToken(t *testing.T) {
 	}
 
 	defer func() {
-		db.DeleteUser(_context.TODO(), u)
+		_ = db.DeleteUser(_context.TODO(), u)
 		db.Close()
 	}()
 

diff --git a/router/middleware/logger.go b/router/middleware/logger.go
@@ -134,12 +134,14 @@ func (f *ECSFormatter) Format(e *logrus.Entry) ([]byte, error) {
 	if f.DataKey != "" {
 		datahint = 2
 	}
+
 	data := make(logrus.Fields, datahint)
 	if len(e.Data) > 0 {
 		extraData := data
 		if f.DataKey != "" {
 			extraData = make(logrus.Fields, len(e.Data))
 		}
+
 		for k, v := range e.Data {
 			switch k {
 			case "ip":
@@ -160,6 +162,7 @@ func (f *ECSFormatter) Format(e *logrus.Entry) ([]byte, error) {
 				extraData[k] = v
 			}
 		}
+
 		if f.DataKey != "" && len(extraData) > 0 {
 			data[f.DataKey] = extraData
 		}

diff --git a/router/middleware/org/org_test.go b/router/middleware/org/org_test.go
@@ -64,7 +64,7 @@ func TestOrg_Establish(t *testing.T) {
 	}
 
 	defer func() {
-		db.DeleteRepo(context.TODO(), r)
+		_ = db.DeleteRepo(context.TODO(), r)
 		db.Close()
 	}()