chore: verbose comment on fallback user fetch

go-vela · Jun 4, 2024 · 7625a96 · 7625a96
1 parent 242ebf9
commit 7625a96
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/api/webhook/post.go b/api/webhook/post.go
@@ -208,6 +208,8 @@ func PostWebhook(c *gin.Context) {
 	}
 
 	// attach a sender SCM id if the webhook payload from the SCM has no sender id
+	// the code in ProcessWebhook implies that the sender may not always be present
+	// fallbacks like pusher/commit_author do not have an id
 	if len(b.GetSenderSCMID()) == 0 || b.GetSenderSCMID() == "0" {
 		// fetch scm user id for pusher
 		senderID, err := scm.FromContext(c).GetUserID(ctx, b.GetSender(), repo.GetOwner().GetToken())