-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add types, fix errors, add conditional status report #1071
Conversation
go.mod
Outdated
@@ -2,6 +2,8 @@ module github.com/go-vela/server | |||
|
|||
go 1.21 | |||
|
|||
replace github.com/go-vela/types => ../types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
local replacement are not allowed: github.com/go-vela/types (gomoddirectives)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one suggestion, otherwise looks fine to me.
scm/github/github.go
Outdated
@@ -186,17 +202,28 @@ func (c *client) newClientToken(token string) *github.Client { | |||
} | |||
|
|||
// helper function to return the GitHub App token. | |||
func (c *client) newGithubAppToken(r *library.Repo) *github.Client { | |||
func (c *client) newGithubAppToken(r *library.Repo) (*github.Client, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommendation: looks like it returns a client using a token, not the token itself. maybe remove Token
suffix and update comment?
No description provided.