Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add types, fix errors, add conditional status report #1071

Closed
wants to merge 6 commits into from

Conversation

ecrupper
Copy link
Contributor

No description provided.

@ecrupper ecrupper requested a review from a team as a code owner February 28, 2024 16:51
go.mod Outdated
@@ -2,6 +2,8 @@ module github.com/go-vela/server

go 1.21

replace github.com/go-vela/types => ../types

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
local replacement are not allowed: github.com/go-vela/types (gomoddirectives)

@wass3rw3rk
Copy link
Member

wass3rw3rk commented Apr 2, 2024

if this doesn't need review atm, can we change to draft PR? ah this is going into the other PR/branch.

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion, otherwise looks fine to me.

@@ -186,17 +202,28 @@ func (c *client) newClientToken(token string) *github.Client {
}

// helper function to return the GitHub App token.
func (c *client) newGithubAppToken(r *library.Repo) *github.Client {
func (c *client) newGithubAppToken(r *library.Repo) (*github.Client, error) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommendation: looks like it returns a client using a token, not the token itself. maybe remove Token suffix and update comment?

@ecrupper ecrupper closed this Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants