Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch(v0.23.4): apply approve build fix + upgrade types #1091

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

ecrupper
Copy link
Contributor

Applying #1088 to v0.23.4-patch for patch release.

@ecrupper ecrupper requested a review from a team as a code owner March 21, 2024 17:57
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.64%. Comparing base (f77ef48) to head (5b21246).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           v0.23.4-patch    #1091   +/-   ##
==============================================
  Coverage          62.64%   62.64%           
==============================================
  Files                345      345           
  Lines              10304    10304           
==============================================
  Hits                6455     6455           
  Misses              3373     3373           
  Partials             476      476           

Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing that

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ecrupper ecrupper merged commit de10e53 into v0.23.4-patch Mar 21, 2024
9 of 11 checks passed
@ecrupper ecrupper deleted the patch/approve-build branch March 21, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants