Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(schedule): add next run field to schedule #1131

Merged
merged 8 commits into from
May 17, 2024

Conversation

wsan3
Copy link
Contributor

@wsan3 wsan3 commented May 15, 2024

Description

Add a "next run" field to the schedule object so that we can display when a schedule is going to run NEXT.

Desired View

Screenshot 2024-05-15 at 10 06 04 AM

Related

go-vela/community#871

@wsan3 wsan3 added the enhancement Indicates an improvement to a feature label May 15, 2024
@wsan3 wsan3 self-assigned this May 15, 2024
@wsan3 wsan3 requested a review from a team as a code owner May 15, 2024 15:34
database/schedule/get.go Outdated Show resolved Hide resolved
database/schedule/list.go Outdated Show resolved Hide resolved
database/schedule/list_active.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 87.50000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 68.08%. Comparing base (178e678) to head (7acd04d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1131      +/-   ##
==========================================
+ Coverage   68.06%   68.08%   +0.02%     
==========================================
  Files         410      410              
  Lines       13699    13715      +16     
==========================================
+ Hits         9324     9338      +14     
- Misses       3841     3842       +1     
- Partials      534      535       +1     
Files Coverage Δ
api/types/schedule.go 100.00% <100.00%> (ø)
database/schedule/update.go 76.47% <ø> (ø)
mock/server/schedule.go 0.00% <ø> (ø)
database/types/schedule.go 96.92% <66.66%> (-3.08%) ⬇️

api/types/schedule.go Outdated Show resolved Hide resolved
database/types/schedule.go Outdated Show resolved Hide resolved
@wsan3 wsan3 merged commit c35d01e into main May 17, 2024
14 of 16 checks passed
@wsan3 wsan3 deleted the enhance/show-next-scheduled-run branch May 17, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Indicates an improvement to a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants