Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jwk): upgrade lestrrat-go/jwx to v2 #1138

Merged
merged 2 commits into from
Jun 7, 2024
Merged

fix(jwk): upgrade lestrrat-go/jwx to v2 #1138

merged 2 commits into from
Jun 7, 2024

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Jun 6, 2024

Didn't even realize there was a v2 until renovate popped up with the upgrade. There's a few differences, so this PR addresses all those. No change in functionality.

@ecrupper ecrupper requested a review from a team as a code owner June 6, 2024 14:50
Copy link

codecov bot commented Jun 6, 2024

Codecov Report

Attention: Patch coverage is 20.58824% with 27 lines in your changes missing coverage. Please review.

Project coverage is 51.98%. Comparing base (dc8b3f6) to head (824c9ee).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1138      +/-   ##
==========================================
- Coverage   52.01%   51.98%   -0.03%     
==========================================
  Files         548      548              
  Lines       18779    18791      +12     
==========================================
+ Hits         9767     9768       +1     
- Misses       8457     8465       +8     
- Partials      555      558       +3     
Files Coverage Δ
database/jwk/create.go 100.00% <ø> (ø)
database/jwk/get.go 100.00% <ø> (ø)
database/testutils/mock_args.go 71.42% <ø> (ø)
database/types/jwk.go 83.33% <ø> (ø)
mock/server/authentication.go 0.00% <ø> (ø)
database/jwk/list.go 75.00% <33.33%> (-10.72%) ⬇️
database/testutils/api_resources.go 95.74% <50.00%> (-2.51%) ⬇️
internal/token/generate_rsa.go 0.00% <0.00%> (ø)

database/jwk/list.go Outdated Show resolved Hide resolved
database/jwk/list_test.go Outdated Show resolved Hide resolved
database/jwk/list_test.go Outdated Show resolved Hide resolved
database/integration_test.go Outdated Show resolved Hide resolved
database/integration_test.go Outdated Show resolved Hide resolved
internal/token/generate_rsa.go Outdated Show resolved Hide resolved
internal/token/generate_rsa.go Outdated Show resolved Hide resolved
internal/token/generate_rsa.go Outdated Show resolved Hide resolved
@ecrupper ecrupper merged commit ad8e820 into main Jun 7, 2024
14 of 16 checks passed
@ecrupper ecrupper deleted the chore/upgrade-jwx branch June 7, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants