Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only convert commands query param when provided #1140

Merged
merged 2 commits into from
Jun 10, 2024
Merged

fix: only convert commands query param when provided #1140

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c51ffd
fix: only convert commands query param when provided
plyr4 Jun 7, 2024
a50c531
fix: lint
plyr4 Jun 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions api/build/id_request_token.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,13 +113,18 @@
return
}

commands, err := strconv.ParseBool(c.Query("commands"))
if err != nil {
retErr := fmt.Errorf("unable to parse 'commands' query parameter as boolean %s: %w", c.Query("commands"), err)
commands := false
var err error

Check failure on line 117 in api/build/id_request_token.go

View workflow job for this annotation

GitHub Actions / golangci

[golangci] api/build/id_request_token.go#L117 

declarations should never be cuddled (wsl)
Raw output 
api/build/id_request_token.go:117:2: declarations should never be cuddled (wsl)
	var err error
	^
plyr4 marked this conversation as resolved.
Show resolved Hide resolved

util.HandleError(c, http.StatusBadRequest, retErr)
if len(c.Query("commands")) > 0 {
commands, err = strconv.ParseBool(c.Query("commands"))
if err != nil {
retErr := fmt.Errorf("unable to parse 'commands' query parameter as boolean %s: %w", c.Query("commands"), err)

return
util.HandleError(c, http.StatusBadRequest, retErr)

return
}
}

// retrieve token manager from context
Expand Down
Loading