fix(deps): remove go-jose lib from dependency in tests #1141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1141 +/- ##
=======================================
Coverage 51.97% 51.97%
=======================================
Files 548 548
Lines 18794 18794
=======================================
Hits 9768 9768
Misses 8468 8468
Partials 558 558 |
ecrupper
previously approved these changes
Jun 10, 2024
plyr4
previously approved these changes
Jun 10, 2024
ecrupper
approved these changes
Jun 10, 2024
wass3rw3rk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/go-vela/server/security/dependabot/17 although only used (accidentally?) in tests in our case. we do still have an indirect dependency on the good version of the library.