-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: logging #1145
Merged
Merged
fix: logging #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this also fixes a bug when working with golangci linter in (neo)vim
also includes fixes for swagger annotations
accidental commit
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1145 +/- ##
==========================================
+ Coverage 51.97% 52.15% +0.17%
==========================================
Files 548 550 +2
Lines 18794 18833 +39
==========================================
+ Hits 9768 9822 +54
+ Misses 8468 8447 -21
- Partials 558 564 +6
|
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
plyr4
reviewed
Jun 18, 2024
removes "in the/from (the) database" wording from log messages within the database package, they should all have "database": "<database engine>" as a log field anwyay. also removes it from api package.
ecrupper
previously approved these changes
Jun 20, 2024
ecrupper
approved these changes
Jun 20, 2024
plyr4
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sweet, thanks for the followups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is focused on various logging fixes and accomplishes the following:
router/middleware/logger.go
Note: this PR also addresses some swagger annotations issues discovered (missed in #1139)