Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use builtin min/max funcs #1148

Merged
merged 8 commits into from
Aug 20, 2024
Merged

refactor: use builtin min/max funcs #1148

merged 8 commits into from
Aug 20, 2024

Conversation

wass3rw3rk
Copy link
Member

@wass3rw3rk wass3rw3rk commented Jun 18, 2024

see "Changes to the language" for Go 1.21 release notes or the spec

@wass3rw3rk wass3rw3rk requested a review from a team as a code owner June 18, 2024 20:02
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 52.18%. Comparing base (8b07da9) to head (eb42802).
Report is 1 commits behind head on main.

Files Patch % Lines
api/repo/update.go 0.00% 4 Missing ⚠️
api/build/list_org.go 0.00% 1 Missing ⚠️
api/build/list_repo.go 0.00% 1 Missing ⚠️
api/deployment/list.go 0.00% 1 Missing ⚠️
api/hook/list.go 0.00% 1 Missing ⚠️
api/log/list_build.go 0.00% 1 Missing ⚠️
api/pipeline/list.go 0.00% 1 Missing ⚠️
api/repo/list.go 0.00% 1 Missing ⚠️
api/repo/list_org.go 0.00% 1 Missing ⚠️
api/schedule/list.go 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1148      +/-   ##
==========================================
+ Coverage   52.11%   52.18%   +0.07%     
==========================================
  Files         550      550              
  Lines       18859    18833      -26     
==========================================
  Hits         9828     9828              
+ Misses       8469     8443      -26     
  Partials      562      562              
Files Coverage Δ
util/util.go 18.86% <ø> (+2.47%) ⬆️
api/build/list_org.go 0.00% <0.00%> (ø)
api/build/list_repo.go 0.00% <0.00%> (ø)
api/deployment/list.go 0.00% <0.00%> (ø)
api/hook/list.go 0.00% <0.00%> (ø)
api/log/list_build.go 0.00% <0.00%> (ø)
api/pipeline/list.go 0.00% <0.00%> (ø)
api/repo/list.go 0.00% <0.00%> (ø)
api/repo/list_org.go 0.00% <0.00%> (ø)
api/schedule/list.go 0.00% <0.00%> (ø)
... and 5 more

@wass3r wass3r self-assigned this Jul 14, 2024
@wass3rw3rk wass3rw3rk merged commit 563ff52 into main Aug 20, 2024
11 of 13 checks passed
@wass3rw3rk wass3rw3rk deleted the refactor/use-go-minmax branch August 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants