Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct build links to steps for commit status updates #1150

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

wass3r
Copy link
Collaborator

@wass3r wass3r commented Jun 23, 2024

this was modified in the UI with the refactor but not updated for sending step specific commit statuses to the SCM. "Details" links shown in the GitHub UI will still bring you to the right build, it just won't auto-expand any targeted step.

old format: <domain>/org/repo/1#step:3
new format: <domain>/org/repo/1#3

this was modified in the UI with the refactor but not updated for
sending commit statuses to the SCM
@wass3r wass3r requested a review from a team as a code owner June 23, 2024 20:12
Copy link

codecov bot commented Jun 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.15%. Comparing base (4fd820a) to head (6735c30).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1150   +/-   ##
=======================================
  Coverage   52.15%   52.15%           
=======================================
  Files         550      550           
  Lines       18833    18833           
=======================================
  Hits         9822     9822           
  Misses       8447     8447           
  Partials      564      564           
Files Coverage Δ
scm/github/repo.go 76.55% <100.00%> (ø)

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KellyMerrick KellyMerrick merged commit 06eec42 into main Jun 24, 2024
15 of 17 checks passed
@KellyMerrick KellyMerrick deleted the fix/status-links branch June 24, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants