fix(webhook): only send one response to client #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
during webhook processing some of the helper function can set a status response for the client while the callee is also doing so. this can cause a warning that the status is being set multiple times when they differ. this change puts the responsibility on the caller of the helper functions to return a response to the client - once.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1154 +/- ##
=======================================
Coverage 52.11% 52.11%
=======================================
Files 550 550
Lines 18857 18855 -2
=======================================
Hits 9827 9827
+ Misses 8468 8466 -2
Partials 562 562
|
ecrupper
approved these changes
Jun 28, 2024
plyr4
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
during webhook processing some of the helper function can set a status response for the client while the callee is also doing so. this can cause a warning that the status is being set multiple times when they differ. this change puts the responsibility on the caller of the helper functions to return a response to the client - once.