Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance(token): add info logging on created private key, debug for minted ID token #1155

Merged
merged 2 commits into from
Jul 11, 2024

Conversation

ecrupper
Copy link
Contributor

These two situations should probably be logged.

@ecrupper ecrupper requested a review from a team as a code owner June 28, 2024 21:06
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 52.14%. Comparing base (02047db) to head (a2fc52e).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
- Coverage   52.15%   52.14%   -0.01%     
==========================================
  Files         550      550              
  Lines       18839    18841       +2     
==========================================
  Hits         9825     9825              
- Misses       8452     8454       +2     
  Partials      562      562              
Files Coverage Δ
internal/token/generate_rsa.go 0.00% <0.00%> (ø)
internal/token/mint.go 19.10% <0.00%> (-0.22%) ⬇️

@ecrupper ecrupper merged commit bc77ee7 into main Jul 11, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/tm-logs-generate-rsa branch July 11, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants