-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(oidc): provide support for custom issuer #1160
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1160 +/- ##
==========================================
- Coverage 52.14% 52.11% -0.04%
==========================================
Files 550 550
Lines 18842 18857 +15
==========================================
+ Hits 9825 9827 +2
- Misses 8455 8468 +13
Partials 562 562
|
sweet, i think we also need it here edit: no, thats meant to be hit by the worker holding the request token... |
also should we add url validation for
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This change will allow platform admins to publish the OpenID configuration (and in turn the JWKS) to custom URLs.
Of course, in order to have accurate information, these custom URLs will need to source their data from the standard Vela routes. But this allows selective exposure of OpenID data to external services such as GCP and AWS.