Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webhook): use correct repo variable to populate client credentials #1162

Merged
merged 2 commits into from
Jul 18, 2024

Conversation

ecrupper
Copy link
Contributor

r is what we get from parsing SCM webhook; repo is what we have in the database. Need the latter to gather proper credentials for contributor call.

@ecrupper ecrupper requested a review from a team as a code owner July 18, 2024 15:13
Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.14%. Comparing base (bc77ee7) to head (17f40cf).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1162   +/-   ##
=======================================
  Coverage   52.14%   52.14%           
=======================================
  Files         550      550           
  Lines       18841    18841           
=======================================
  Hits         9825     9825           
  Misses       8454     8454           
  Partials      562      562           
Files Coverage Δ
api/webhook/post.go 0.00% <0.00%> (ø)

@ecrupper ecrupper merged commit 75a9ee6 into main Jul 18, 2024
11 of 13 checks passed
@ecrupper ecrupper deleted the fix/approve-build/correct-repo-var branch July 18, 2024 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants