Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: required changes from api build types migration #1204

Closed
wants to merge 1 commit into from

Conversation

plyr4
Copy link
Contributor

@plyr4 plyr4 commented Oct 4, 2024

need this to let the worker build in go-vela/worker#608

this is subject to change when pipeline and step are migrated, but until then we need it to build the worker

cd go-vela/worker

make build

executor/local/step.go:53:50: c.build.ToLibrary undefined (type *"github.com/go-vela/server/api/types".Build has no field or method ToLibrary)

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 53.74%. Comparing base (2960513) to head (7e8a676).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
api/types/build.go 0.00% 16 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1204      +/-   ##
==========================================
+ Coverage   53.04%   53.74%   +0.70%     
==========================================
  Files         559      561       +2     
  Lines       19743    19965     +222     
==========================================
+ Hits        10473    10731     +258     
+ Misses       8701     8661      -40     
- Partials      569      573       +4     
Files with missing lines Coverage Δ
api/types/build.go 95.70% <0.00%> (+3.93%) ⬆️

... and 3 files with indirect coverage changes

@wass3rw3rk
Copy link
Member

not needed anymore

@wass3rw3rk wass3rw3rk closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants