Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(database): add integration testing #896

Merged
merged 98 commits into from
Jul 31, 2023
Merged

Conversation

jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp commented Jun 28, 2023

This change adds integration tests for the database package.

NOTE: This is already paying off 😄

@jbrockopp jbrockopp self-assigned this Jun 28, 2023
@codecov
Copy link

codecov bot commented Jun 28, 2023

Codecov Report

Merging #896 (061ff80) into main (02fcd74) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #896   +/-   ##
=======================================
  Coverage   71.47%   71.47%           
=======================================
  Files         304      304           
  Lines       12454    12455    +1     
=======================================
+ Hits         8901     8902    +1     
  Misses       3120     3120           
  Partials      433      433           
Files Changed Coverage Δ
database/hook/table.go 100.00% <ø> (ø)
database/log/list_build.go 80.85% <100.00%> (+0.41%) ⬆️

@jbrockopp jbrockopp marked this pull request as ready for review July 3, 2023 14:16
@jbrockopp jbrockopp requested a review from a team as a code owner July 3, 2023 14:16
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way we keep track of "coverage" still feels a bit goofy, but i don't have a better alternative. thanks for all this work!

database/hook/table.go Show resolved Hide resolved
@wass3rw3rk wass3rw3rk merged commit adf4f65 into main Jul 31, 2023
12 of 13 checks passed
@wass3rw3rk wass3rw3rk deleted the hackathon/integration branch July 31, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants