-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance(logging): add flag to allow logging in ecs format, map custom fields to ecs fields #971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #971 +/- ##
==========================================
+ Coverage 70.98% 71.09% +0.10%
==========================================
Files 312 312
Lines 12934 12982 +48
==========================================
+ Hits 9181 9229 +48
Misses 3288 3288
Partials 465 465
|
plyr4
reviewed
Sep 26, 2023
plyr4
reviewed
Sep 26, 2023
plyr4
reviewed
Sep 26, 2023
plyr4
reviewed
Sep 26, 2023
plyr4
reviewed
Sep 26, 2023
wass3rw3rk
requested changes
Sep 26, 2023
wass3rw3rk
approved these changes
Sep 27, 2023
timhuynh94
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add flag to allow logging in Elasticsearch Common Schema (ECS) format. Default will remain
logrus.JSONFormatter
.Custom Vela fields will be nested under
labels.vela
, which allows separation from other non-Vela custom labels that may exist in one's logging stack.server/cmd/vela-server/main.go
Lines 51 to 56 in a000fd0
server/cmd/vela-server/server.go
Lines 29 to 39 in a000fd0
As noted below, a custom formatter, borrowing from ecslogrus, was created to handle Vela custom fields.
server/router/middleware/logger.go
Lines 23 to 25 in a000fd0
server/router/middleware/logger.go
Lines 145 to 192 in a000fd0
default log:
ecs formatted log: