feat: endpoint for validating oauth token source #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plyr4
changed the title
Codecov Report
@@ Coverage Diff @@
## main #972 +/- ##
=======================================
Coverage 71.09% 71.09%
=======================================
Files 312 312
Lines 12982 12989 +7
=======================================
+ Hits 9229 9235 +6
Misses 3288 3288
- Partials 465 466 +1
|
wass3rw3rk
previously approved these changes
Sep 27, 2023
timhuynh94
previously approved these changes
Sep 27, 2023
wass3rw3rk
reviewed
Sep 27, 2023
wass3rw3rk
approved these changes
Sep 27, 2023
timhuynh94
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the following PR refactors oauth token validation into its own function and exposes the functionality through an API endpoint.
the purpose is to allow users to pass back tokens embedded by vela pipelines to validate that they were indeed created by Vela. it is meant to also improve the security around third-party integrated tooling.
AuthenticateTokenhas been refactored to use the new func, but it is functionally identical.closes go-vela/community#854