fix(admin/clean): clean executable when build is cleaned #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #988 +/- ##
==========================================
+ Coverage 71.03% 71.10% +0.06%
==========================================
Files 312 313 +1
Lines 13018 13028 +10
==========================================
+ Hits 9247 9263 +16
+ Misses 3303 3299 -4
+ Partials 468 466 -2
|
wass3r
previously approved these changes
Oct 14, 2023
wass3rw3rk
reviewed
Oct 16, 2023
plyr4
approved these changes
Oct 17, 2023
wass3rw3rk
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As builds tend to get stuck in
pendingorrunningstates, the clean endpoint has been great for routine clean up. However, it didn't clear the executable from the DB, which will only sit there forever without manual intervention before this change.