Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api/build): pop executable when pending build is auto canceled #990

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

ecrupper
Copy link
Contributor

A missing component of this fix

@ecrupper ecrupper requested a review from a team as a code owner October 23, 2023 14:56
@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #990 (4208ce6) into main (b51d5a2) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
- Coverage   70.39%   70.36%   -0.03%     
==========================================
  Files         315      315              
  Lines       13195    13199       +4     
==========================================
  Hits         9288     9288              
- Misses       3440     3444       +4     
  Partials      467      467              
Files Coverage Δ
api/build/auto_cancel.go 0.00% <0.00%> (ø)

@ecrupper ecrupper merged commit 7370602 into main Oct 23, 2023
11 of 12 checks passed
@ecrupper ecrupper deleted the fix/auto_cancel/pop-executable branch October 23, 2023 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants