feat: build graph endpoint for pipeline visualization #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #995 +/- ##
==========================================
- Coverage 70.37% 68.42% -1.96%
==========================================
Files 316 317 +1
Lines 13209 13586 +377
==========================================
Hits 9296 9296
- Misses 3446 3823 +377
Partials 467 467
|
ecrupper
requested changes
Oct 27, 2023
Co-authored-by: Easton Crupper <[email protected]>
wass3rw3rk
reviewed
Nov 1, 2023
|
one parting thought, should we try and fetch pipeline first and make calls to get steps/services dependent on whether pipeline has steps/services? might save some db calls, esp for services? ref: server/database/pipeline/table.go Lines 27 to 29 in 6708cea |
ecrupper
previously approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Very cool. Opened an issue related to the discussion @cognifloyd and @plyr4 had in this PR: go-vela/community#874
timhuynh94
previously approved these changes
Nov 1, 2023
plyr4
dismissed stale reviews from timhuynh94, ecrupper, and wass3r
via
f589dce
timhuynh94
previously approved these changes
Nov 1, 2023
cognifloyd
previously approved these changes
Nov 2, 2023
plyr4
dismissed stale reviews from cognifloyd, wass3r, and timhuynh94
via
aee68c2
claire1618
approved these changes
Nov 2, 2023
wass3rw3rk
approved these changes
Nov 2, 2023
timhuynh94
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meant to work with ui changes in go-vela/ui#731
the new endpoint aggregates resources for a build and generates a directed graph consisting of nodes and edges.
needsthere are 3 node groups organized as subgraph clusters for visual effect.
closes go-vela/community#71