Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api/schedule): early exit for empty name #996

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

ecrupper
Copy link
Contributor

Before:

{
    "error": "schedule name must be set"
}{
    "error": "unable to create new schedule myvela: empty schedule name provided"
}

After:

{
    "error": "schedule name must be set"
}

UI can't handle the first one and just prints Status 400

@ecrupper ecrupper requested a review from a team as a code owner October 30, 2023 15:15
@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #996 (9197815) into main (262d7f0) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #996      +/-   ##
==========================================
- Coverage   70.36%   70.35%   -0.02%     
==========================================
  Files         315      315              
  Lines       13199    13201       +2     
==========================================
  Hits         9288     9288              
- Misses       3444     3446       +2     
  Partials      467      467              
Files Coverage Δ
api/schedule/create.go 13.86% <0.00%> (-0.21%) ⬇️

@ecrupper ecrupper merged commit 3ee9ccf into main Oct 30, 2023
11 of 12 checks passed
@ecrupper ecrupper deleted the fix/api/schedule/no-name-error branch October 30, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants