Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schedule): honor allow list for previously created schedules #998

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Nov 2, 2023

This change makes sure that any repo taken off of the allowlist does not continue to trigger existing schedules

@ecrupper ecrupper self-assigned this Nov 2, 2023
@ecrupper ecrupper requested a review from a team as a code owner November 2, 2023 16:28
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. the arity of that function is getting a little out of hand, probably time for a struct 🫣

Copy link

codecov bot commented Nov 2, 2023

Codecov Report

Merging #998 (6ab28f7) into main (6708cea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #998   +/-   ##
=======================================
  Coverage   70.37%   70.37%           
=======================================
  Files         316      316           
  Lines       13209    13209           
=======================================
  Hits         9296     9296           
  Misses       3446     3446           
  Partials      467      467           

@ecrupper ecrupper merged commit a22bbad into main Nov 2, 2023
11 checks passed
@ecrupper ecrupper deleted the fix/scheduler/allow_list_check branch November 2, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants